Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use model to translate operationInput parameters #3133

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

alextwoods
Copy link
Contributor

@alextwoods alextwoods commented Oct 29, 2024

Example operationInputTest with issue:

"operationName": "BatchGetItem",
                    "operationParams": {
                        "RequestItems": {
                            "arn:aws:dynamodb:us-east-1:333333333333:table/table_name": {
                                "Keys": [
                                    {
                                        "pk": {
                                            "S": "value"
                                        }
                                    }
                                ]
                            }
                        }
                    }

Before:

resp = client.batch_get_item(
          request_items: {:arn_aws_dynamodb_us_east_1_333333333333_table_table_name=>{:keys=>[{:pk=>{:s=>"value"}}]}},
        )

After:

resp = client.batch_get_item(
          request_items: {"arn:aws:dynamodb:us-east-1:333333333333:table/table_name"=>{:keys=>[{"pk"=>{:s=>"value"}}]}},
        )

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

@alextwoods alextwoods requested a review from mullermp October 29, 2024 23:33
@alextwoods alextwoods merged commit 9872daf into version-3 Oct 31, 2024
30 checks passed
@jterapin jterapin deleted the fix_operation_inputs branch November 1, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants